feat: dynamically set meta tags #1453
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| transform: 'rotate(180deg)', | ||
| mixBlendMode: 'overlay', | ||
| backgroundImage: | ||
| 'url("https://arbitrum.io/background/grains_bottom.png")', |
There was a problem hiding this comment.
Can we have it as part of this repo, we had issues in the past where images were moved on arbitrum.io
There was a problem hiding this comment.
relative url does not work with satori.... only possible alternatives are
- change the element layout, and use this png in base64 form, or
- keep the image here, and do not use the current version but refer to prod
bridge.arbitrum.ioversion
I think given that it's just grains for artistic effect, it's ok to use arbitrum.io, it's also not so bad if it's gone missing because the bg would just become pure black
There was a problem hiding this comment.
Can we move it to bridge.arbitrum.io?
| height={168} | ||
| /> | ||
| <img | ||
| src={`data:image/png;base64,${imageContent.toString('base64')}`} |
There was a problem hiding this comment.
Can we use the image directly instead?
There was a problem hiding this comment.
as above, no
- relative links don't work, and
- svg format doesn't work
…token-bridge into feat-dynamic-meta
fionnachan
requested review from
dewanshparashar
and removed request for
douglance
| </span> | ||
| <img | ||
| src={chainToLogo[chain]} | ||
| alt="logo" |
There was a problem hiding this comment.
We should have the chain's name + logo in alt text
| [ | ||
| customInfuraProvider(), | ||
| publicProvider(), | ||
| jsonRpcProvider({ |
There was a problem hiding this comment.
Why is this diff required in this PR?
There was a problem hiding this comment.
it is because otherwise the transfer panel will not render
closes FS-238