feat: network box redesign #1893
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…e into network-box-redesign
…e into network-box-redesign
| @@ -11,20 +11,25 @@ export function SafeImage(props: SafeImageProps) { | |||
| const [validImageSrc, setValidImageSrc] = useState<false | string>(false) | |||
|
|
|||
| useEffect(() => { | |||
| let mounted = true | |||
There was a problem hiding this comment.
Need to track this, otherwise there are side effects when changing networks and token logos not updating
| const tokenLogoSrc = useMemo(() => { | ||
| if (parentErc20Address) { | ||
| return ( | ||
| tokensFromLists[parentErc20Address]?.logoURI ?? | ||
| tokensFromUser[parentErc20Address]?.logoURI | ||
| ) | ||
| } | ||
|
|
||
| return nativeCurrency.logoUrl | ||
| }, [ | ||
| nativeCurrency.logoUrl, | ||
| parentErc20Address, | ||
| tokensFromLists, | ||
| tokensFromUser | ||
| ]) |
There was a problem hiding this comment.
same code as in TokenButton.tsx, can you reuse them please?
| }) | ||
| : undefined | ||
| } | ||
| symbolOverride={isCctpTransfer ? 'USDC.e' : undefined} |
There was a problem hiding this comment.
if it's CCTP, and it's withdrawal mode, the destination chain's (parent chain) symbol should be USDC, because the source chain (child chain) USDC would be the native USDC.
| const symbol = useMemo(() => { | ||
| if (symbolOverride) { | ||
| return symbolOverride | ||
| } | ||
|
|
||
| if (parentErc20Address) { | ||
| return ( | ||
| tokensFromLists[parentErc20Address]?.symbol ?? | ||
| tokensFromUser[parentErc20Address]?.symbol | ||
| ) | ||
| } | ||
|
|
||
| return nativeCurrency.symbol | ||
| }, [ | ||
| symbolOverride, | ||
| nativeCurrency.symbol, | ||
| parentErc20Address, | ||
| tokensFromLists, | ||
| tokensFromUser | ||
| ]) |
There was a problem hiding this comment.
this is not working for Arb One/Sepolia native USDC -> Orbit chain
note the empty token symbol
can you check if you need the usage of sanitizeTokenSymbol because it handles all these cases and was the reason why we had it in the first place
closes FS-1012