Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the gas estimation tutorial not working on arbitrum goerli #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the gas estimation tutorial not working on arbitrum goerli #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/gas-estimation/scripts/exec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,14 @@ const gasEstimator = async () => {
// NOTE: This one might be a bit confusing, but l1GasEstimated (B in the formula) is calculated based on l2 gas fees
const l1Cost = l1GasEstimated.mul(l2EstimatedPrice);
// NOTE: This is similar to 140 + utils.hexDataLength(txData);
const l1Size = l1Cost.div(l1EstimatedPrice);

let l1Size;
if(l1EstimatedPrice.eq(0)) {
// If the L1 price is 0, we set the size to 0
l1Size = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you cast this as a BigNumber to keep consistency between both sides of the condition?

}else{
l1Size = l1Cost.div(l1EstimatedPrice).add(140);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 140 bytes are already factored in at this point and you don't need to add them. L1 cost has the full cost of the L1 component, including the 140 extra bytes.

}

// Getting the result of the formula
// ---------------------------------
Expand Down