Fix replay command in MacOS #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replay command wasn't working on MacOS because the HostIO symbols
were striped from cargo-stylus. To fix this issue, we have to disable
stripping in the release profile.
This fixes introduces the following warning:
warning: profiles for the non root package will be ignored
We have to edit the profile in the non-root package because the root
package is ignored during cargo install. Otherwise, the solution won't
work after the package is published to crates.io. More information about
this issue is available here:
* rust-lang/cargo#8264
* rust-lang/cargo#11599
rauljordan
approved these changes
Jan 10, 2025
|
Update: Raul released this branch as |
Add #[used] static variables pointing to the exported functions so the linked doesn't remove them from the final binary.
This reverts commit b489394.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replay command wasn't working on MacOS because the HostIO symbols were striped from cargo-stylus. To fix this issue, we have to disable stripping in the release profile.
This fixes introduces the following warning:
We have to edit the profile in the non-root package because the root package is ignored during cargo install. Otherwise, the solution won't work after the package is published to crates.io. More information about this issue is available here: