Add a boolean field to tx receipt object indicating if the tx was timeboosted #369
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristan-Wilson
requested changes
Nov 14, 2024
ganeshvanahalli
changed the base branch from
wasm-store-compile-target
to
add-methodsto-sizeconstrainedcache
…osted-receiptsfield
Tristan-Wilson
previously approved these changes
Nov 20, 2024
Base automatically changed from
add-methodsto-sizeconstrainedcache
to
master
December 30, 2024 19:19
eljobe
previously requested changes
Jan 21, 2025
| if txIndex >= maxTxCount { | ||
| return false, nil | ||
| } | ||
| return b[1+(txIndex/8)]&(1<<(txIndex%8)) != 0, nil |
There was a problem hiding this comment.
This line needs a comment.
8 seems like a magical number and it isn't clear how the bitwise & is checking if the transaction was timeboosted or not.
There was a problem hiding this comment.
I agree. Currently the explanation for this exists on the sequencer side where blockMetadata originates https://github.com/OffchainLabs/nitro/blob/071aa54de1a8c2f510b5d11835bad9124eb38f37/execution/gethexec/executionengine.go#L615-L619 but having it here as well is a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new field to the receipts object/s returned by
eth_getTransactionReceiptandeth_getBlockReceipts, indicating whether a transaction was timeboosted or not. This field is a boolean named astimeboosted.The PR is based of of
wasm-store-compile-targetbranch (revived) instead of master because the current main Timeboost PR's geth pin is pointing to this branch and we do this to be in sync with the main PR.Corresponding nitro PR- OffchainLabs/nitro#2760
Resolves NIT-2836