Skip to content

core: Instrument WasmCallCost with multigas #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −10
Draft

core: Instrument WasmCallCost with multigas #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions core/vm/operations_acl_arbitrum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,17 @@ func WasmStateStoreCost(db StateDB, program common.Address, key, value common.Ha
// The code here is adapted from the following functions with the most recent parameters as of The Merge
// - operations_acl.go makeCallVariantGasCallEIP2929()
// - gas_table.go gasCall()
func WasmCallCost(db StateDB, contract common.Address, value *uint256.Int, budget uint64) (uint64, error) {
total := uint64(0)
apply := func(amount uint64) bool {
total += amount
return total > budget
func WasmCallCost(db StateDB, contract common.Address, value *uint256.Int, budget uint64) (multigas.MultiGas, error) {
total := multigas.ZeroGas()
apply := func(resource multigas.ResourceKind, amount uint64) bool {
total.SaturatingIncrementInto(resource, amount)
return total.SingleGas() > budget
}

// EIP 2929: the static cost
if apply(params.WarmStorageReadCostEIP2929) {
// NOTE: keep ResourceKindWasmComputation, it is used to calculate base cost single gas

// EIP 2929: the static cost considered as computation
if apply(multigas.ResourceKindWasmComputation, params.WarmStorageReadCostEIP2929) {
return total, ErrOutOfGas
}

Expand All @@ -129,20 +131,23 @@ func WasmCallCost(db StateDB, contract common.Address, value *uint256.Int, budge
if !warmAccess {
db.AddAddressToAccessList(contract)

if apply(coldCost) {
// Cold slot access considered as storage access.
if apply(multigas.ResourceKindStorageAccess, coldCost) {
return total, ErrOutOfGas
}
}

// gasCall()
transfersValue := value.Sign() != 0
if transfersValue && db.Empty(contract) {
if apply(params.CallNewAccountGas) {
// Storage slot writes (zero -> nonzero) considered as storage growth.
if apply(multigas.ResourceKindStorageGrowth, params.CallNewAccountGas) {
return total, ErrOutOfGas
}
}
if transfersValue {
if apply(params.CallValueTransferGas) {
// Value transfer to non-empty account considered as computation.
if apply(multigas.ResourceKindWasmComputation, params.CallValueTransferGas) {
return total, ErrOutOfGas
}
}
Expand All @@ -160,10 +165,12 @@ func WasmAccountTouchCost(cfg *params.ChainConfig, db StateDB, addr common.Addre

if !db.AddressInAccessList(addr) {
db.AddAddressToAccessList(addr)
// Cold slot read -> storage access + computation
return cost.SaturatingAdd(multigas.MultiGasFromPairs(
multigas.Pair{Kind: multigas.ResourceKindStorageAccess, Amount: params.ColdAccountAccessCostEIP2929 - params.WarmStorageReadCostEIP2929},
multigas.Pair{Kind: multigas.ResourceKindComputation, Amount: params.WarmStorageReadCostEIP2929},
))
}
// Warm slot read considered as computation.
return cost.SaturatingIncrement(multigas.ResourceKindComputation, params.WarmStorageReadCostEIP2929)
}
Loading