Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: effectively disableing delay buffer #275

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Dec 10, 2024

If isDelayBufferable is set to false, it is hard to re-enable without doing contract upgrade due to the flag is stored in an immutable for gas optimization. We temporarily disable delay buffer by using a large threshold value so that isSynced return true and will not require a delay proof when posting batches.

    function isSynced(
        BufferData storage self
    ) internal view returns (bool) {
        return block.number - self.prevBlockNumber <= self.threshold;
    }

the previous config for sepolia is not large enough because prevBlockNumber might be 0 after an upgrade

@cla-bot cla-bot bot added the s label Dec 10, 2024
scripts/files/configs/local.ts Outdated Show resolved Hide resolved
scripts/files/configs/sepolia.ts Outdated Show resolved Hide resolved
Co-authored-by: Henry <[email protected]>
@gzeoneth gzeoneth merged commit 2c72296 into bold-merge Dec 10, 2024
10 checks passed
@gzeoneth gzeoneth deleted the bold-merge-config-buffer branch December 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants