Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pebble config options [NIT-2396] #2245

Merged
merged 31 commits into from
May 23, 2024
Merged

add pebble config options [NIT-2396] #2245

merged 31 commits into from
May 23, 2024

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Apr 20, 2024

This PR adds pebble database specific configuration options --persistent.pebble.*. Most of the options are placed in --persistent.pebble.experimental.* section and might not be supported in future.

pulls: OffchainLabs/go-ethereum#306

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Apr 20, 2024
@magicxyyz magicxyyz changed the title add pebble config options add pebble config options [NIT-2396] May 14, 2024
@magicxyyz magicxyyz marked this pull request as ready for review May 15, 2024 19:36
Tristan-Wilson
Tristan-Wilson previously approved these changes May 20, 2024
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower enabled auto-merge May 23, 2024 21:36
@PlasmaPower PlasmaPower merged commit d897c4f into master May 23, 2024
10 checks passed
@PlasmaPower PlasmaPower deleted the pebble-extra-options branch May 23, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants