[NIT-2487] Compares computed block hash with hash provided through input feed #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
diegoximenes
force-pushed
the
compare_hash_from_feed
branch
5 times, most recently
from
21f2971 to
60c0df9
Compare
… places where BlockHash will definitely be nil
…nge of keys to properly prune a range of block hashes from the db
diegoximenes
force-pushed
the
compare_hash_from_feed
branch
from
5841b15 to
70818c5
Compare
tsahee
reviewed
May 15, 2024
…st batch messages block hashes' when pruning block hashes from the db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compares computed block hash with hash provided through input feed.
By now only logging an error if hashes don't match.