Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(das): add support to configure http body limit #2321

Merged
merged 5 commits into from
May 25, 2024
Merged

feat(das): add support to configure http body limit #2321

merged 5 commits into from
May 25, 2024

Conversation

emilianobonassi
Copy link
Contributor

No description provided.

@cla-bot cla-bot
Copy link

cla-bot bot commented May 21, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented May 21, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@emilianobonassi emilianobonassi marked this pull request as ready for review May 21, 2024 07:34
@Tristan-Wilson Tristan-Wilson self-requested a review May 25, 2024 02:38
@hkalodner
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 25, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented May 25, 2024

The cla-bot has been summoned, and re-checked this pull request!

Tristan-Wilson
Tristan-Wilson requested changes May 25, 2024
View reviewed changes
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! Just a couple small comments

cmd/daserver/daserver.go Outdated Show resolved Hide resolved
cmd/genericconf/server.go Outdated Show resolved Hide resolved
@Tristan-Wilson Tristan-Wilson enabled auto-merge May 25, 2024 16:56
auto-merge was automatically disabled May 25, 2024 16:56

Head branch was pushed to by a user without write access

@Tristan-Wilson Tristan-Wilson enabled auto-merge May 25, 2024 16:57
@Tristan-Wilson Tristan-Wilson merged commit 3deb9ca into OffchainLabs:master May 25, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristan-Wilson Tristan-Wilson Tristan-Wilson approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilianobonassi @hkalodner @Tristan-Wilson