Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2740] Horizontal Scaling of Validation Node #2354

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

[NIT-2740] Horizontal Scaling of Validation Node #2354

wants to merge 29 commits into from

Conversation

anodar
Copy link
Contributor

@anodar anodar commented May 30, 2024

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 30, 2024
@anodar anodar changed the base branch from master to sepolia-tooling-merge May 30, 2024 11:19
@anodar anodar mentioned this pull request May 30, 2024
Closed
@anodar anodar requested a review from tsahee May 30, 2024 15:14
tsahee
tsahee reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial

validator/server_arb/redis/consumer.go Outdated Show resolved Hide resolved
validator/client/validation_client.go Show resolved Hide resolved
@anodar anodar requested a review from tsahee June 5, 2024 08:38
@anodar anodar marked this pull request as ready for review June 5, 2024 08:47
@anodar anodar requested a review from amsanghi June 5, 2024 08:47
@anodar anodar closed this Jun 24, 2024
@amsanghi amsanghi reopened this Jul 1, 2024
@amsanghi amsanghi changed the base branch from sepolia-tooling-merge to bold-review July 1, 2024 11:29
@amsanghi amsanghi changed the title Sepolia tooling merge redis [NIT-2645] Sepolia tooling merge redis Jul 1, 2024
@amsanghi amsanghi requested a review from rauljordan July 1, 2024 11:40
@amsanghi amsanghi changed the title [NIT-2645] Sepolia tooling merge redis [NIT-2740] Horizontal Scaling of Validation Node Aug 27, 2024
rauljordan
rauljordan reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin great so far! No comments. Just awaiting some tests so we can merge in

rauljordan
rauljordan previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job! Do you know if there are metrics we can use to track the number of pending requests in grafana?

@amsanghi
Copy link
Contributor

awesome job! Do you know if there are metrics we can use to track the number of pending requests in grafana?

Good point, added a metric at consumer level for pending messages. We can use that to follow the load.

@tsahee tsahee marked this pull request as draft September 27, 2024 17:59
@amsanghi amsanghi marked this pull request as ready for review October 9, 2024 10:37
Base automatically changed from bold-review to master December 6, 2024 20:04
@PlasmaPower PlasmaPower dismissed rauljordan’s stale review December 6, 2024 20:04

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan left review comments

@tsahee tsahee Awaiting requested review from tsahee

@amsanghi amsanghi Awaiting requested review from amsanghi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anodar @amsanghi @rauljordan @tsahee