Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing precompiles comments based on interfaces #2685

Merged

Conversation

TucksonDev
Copy link
Contributor

@TucksonDev TucksonDev commented Sep 20, 2024

This PR updates the comments of the following precompiles:

  • ArbAggregator
  • ArbDebug
  • ArbOwner
  • ArbRetryableTx

Comments are changed based on the comments present in their interfaces, with the exception of ArbDebug.CustomRevert and ArbDebug.LegacyError that don't exist in the ArbDebug interface.

More context on INT-253

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 20, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 204f94f into OffchainLabs:master Dec 12, 2024
16 checks passed
@TucksonDev TucksonDev deleted the add-missing-precompiles-comments branch December 13, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants