Add timeboosted information to broadcast feed #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
ganeshvanahalli
requested review from
Tristan-Wilson,
gligneul and
amsanghi
Tristan-Wilson
requested changes
Sep 27, 2024
ganeshvanahalli
changed the title
Tristan-Wilson
requested changes
Oct 2, 2024
…BlockMetaData when updating message's BatchGasCost
tsahee
requested changes
Nov 20, 2024
| BlockHash: &msgResult.BlockHash, | ||
| // maybe if blockhash is differing we clear out previous timeboosted and not send timeboosted info to broadcasting? |
There was a problem hiding this comment.
Good idea. If blockHash doesn't agree clear BlockMetadata.
There was a problem hiding this comment.
Cool. I think the best place to implement this is in Bulk syncing of missing BlockMetadata PR, since it tracks missing blockMetadata and in there we can clear out blockMetadata and mark it as missing in DB so that it will be refetched later on
|
|
tsahee
requested changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field
blockMetadatato theBroadcastFeedMessagestruct that represents whether a particular transaction in the block was time-boosted or not.The field
blockMetadatais an array of bytes and it starts with a 0 (version) followed by ceil(N/8) number of bytes where N is the number of txs in the block. Basicallynth bit of thekth byte of blockMetadata byte array represents the status of8*(k-1)+(n+1)th transaction, if its 1 means the tx was timeboosted else it wasn't.Example: if blockMetadata array viewed as bits is
00000000 01100101then 2nd, 3rd, 6th and 8th transactions in the block were timeboosted.Resolves NIT-2779