Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2834] Add redis sentinel support #2738

Merged
merged 6 commits into from
Dec 10, 2024
Merged

[NIT-2834] Add redis sentinel support #2738

merged 6 commits into from
Dec 10, 2024

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Oct 15, 2024 •
edited
Loading

Fixes: NIT-2834

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 15, 2024
@amsanghi amsanghi changed the title Add redis sentinel support [NIT-2834] Add redis sentinel support Oct 15, 2024
@amsanghi amsanghi marked this pull request as ready for review October 15, 2024 06:26
joshuacolvin0
joshuacolvin0 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 209f354 into master Dec 10, 2024
16 checks passed
@joshuacolvin0 joshuacolvin0 deleted the redis_sentinel branch December 10, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amsanghi @joshuacolvin0