Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update google-cloud-storage parameters and object retention setting #2794

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: update google-cloud-storage parameters and object retention setting #2794

wants to merge 4 commits into from

Conversation

antonio-altr
Copy link

@antonio-altr antonio-altr commented Nov 19, 2024 •
edited
Loading

  1. Changed google-cloud-storage parameters around retention/expiry
  2. Avoided changing the entire bucket's retention policy; instead, add expiration/lifecycle policy to individual objects created (like what we do in s3-storage)
  3. Updated the HealthCheck permissions list

@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 19, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 19, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 19, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@hkalodner
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Nov 19, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 19, 2024

The cla-bot has been summoned, and re-checked this pull request!

joshuacolvin0
joshuacolvin0 requested changes Nov 19, 2024
View reviewed changes
das/google_cloud_storage_service.go
EnableExpiry bool `koanf:"enable-expiry"`
MaxRetention time.Duration `koanf:"max-retention"`
Enable bool `koanf:"enable"`
AccessTokenFile string `koanf:"access-token-file"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to leave support for access-token as well as add support for access-token-file for maximum flexibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonio-altr @hkalodner @joshuacolvin0