Add flag to disable DAS chunked stores #2796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
ganeshvanahalli
requested review from
Tristan-Wilson,
gligneul and
magicxyyz
gligneul
reviewed
Nov 28, 2024
Tristan-Wilson
previously requested changes
Dec 9, 2024
gligneul
approved these changes
Dec 11, 2024
joshuacolvin0
dismissed
Tristan-Wilson’s stale review
Gabriel already re-reviewed
| @@ -92,6 +92,7 @@ type ClientStoreConfig struct { | |||
| SigningWallet string `koanf:"signing-wallet"` | |||
| SigningWalletPassword string `koanf:"signing-wallet-password"` | |||
| MaxStoreChunkBodySize int `koanf:"max-store-chunk-body-size"` | |||
| EnableChunkedStore bool `koanf:"enable-chunked-store"` | |||
There was a problem hiding this comment.
It is a little confusing having to do enable-chunked-store=false, how about changing the option to disable-chunked-store?
There was a problem hiding this comment.
Earlier it was named to disable-chunked-store but following a discussion with gabriel to avoid boolean flags with negative assertions here i changed it to enable-chunked-store
There was a problem hiding this comment.
This is a recurring theme, and, in general, I prefer flags/bools to be worded in a positive sense. I think @eljobe was the first one to bring this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config option-
use-legacy-storethat forces the das rpc clients to usedas_store(legacy) instead ofdas_startChunkedStore.Resolves NIT-2949