Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter transaction #2807

Merged
merged 13 commits into from
Dec 28, 2024
Merged

Filter transaction #2807

merged 13 commits into from
Dec 28, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Nov 26, 2024 •
edited
Loading

This PR adds a system test to showcase tx and block filtering via a stateDB object

Pulls in Geth PR- OffchainLabs/go-ethereum#377
Resolves NIT-2848

@ganeshvanahalli ganeshvanahalli mentioned this pull request Nov 26, 2024
Merged
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review November 26, 2024 10:45
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 2, 2024
eljobe
eljobe previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsahee
tsahee requested changes Dec 10, 2024
View reviewed changes
system_tests/seq_filter_test.go Show resolved Hide resolved
system_tests/seq_filter_test.go Show resolved Hide resolved
tsahee
tsahee previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, want a review from @PlasmaPower as well

@tsahee tsahee requested a review from PlasmaPower December 11, 2024 20:19
PlasmaPower
PlasmaPower previously requested changes Dec 11, 2024
View reviewed changes
execution/gethexec/sequencer.go Outdated Show resolved Hide resolved
arbos/block_processor.go Outdated Show resolved Hide resolved
arbos/block_processor.go Outdated Show resolved Hide resolved
arbos/block_processor.go Show resolved Hide resolved
eljobe
eljobe previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eljobe
eljobe previously approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsahee
tsahee previously approved these changes Dec 27, 2024
View reviewed changes
@ganeshvanahalli ganeshvanahalli dismissed stale reviews from tsahee and eljobe via a54d33d December 27, 2024 23:23
tsahee
tsahee approved these changes Dec 28, 2024
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshvanahalli ganeshvanahalli merged commit 70dcc3d into master Dec 28, 2024
16 checks passed
@ganeshvanahalli ganeshvanahalli deleted the arb-tx-filter branch December 28, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee approved these changes

@eljobe eljobe eljobe left review comments

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

@PlasmaPower PlasmaPower Awaiting requested review from PlasmaPower

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganeshvanahalli @eljobe @PlasmaPower @tsahee