Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ensure-rollup-deployment to false in testnode #2831

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

gligneul
Copy link
Contributor

Disable this feature because the testnode doesn't support finalized blocks.
Otherwise, the Docker CI fails. This issue was introduced on #2582

Depends on OffchainLabs/nitro-testnode#102

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 12, 2024
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 895ddaf into master Dec 12, 2024
18 checks passed
@PlasmaPower PlasmaPower deleted the gligneul/fix/ensure-rollup-creation branch December 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants