Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for how many Stylus calls and gas used #2852

Merged
merged 8 commits into from
Jan 3, 2025
Merged

Add metrics for how many Stylus calls and gas used #2852

merged 8 commits into from
Jan 3, 2025

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Dec 23, 2024 •
edited
Loading

Fixes: NIT-2988, NIT-2989

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 23, 2024
@amsanghi amsanghi marked this pull request as ready for review December 23, 2024 13:55
tsahee
tsahee requested changes Dec 24, 2024
View reviewed changes
arbos/programs/programs.go Outdated Show resolved Hide resolved
tsahee
tsahee requested changes Dec 26, 2024
View reviewed changes
arbos/programs/programs.go Show resolved Hide resolved
@amsanghi amsanghi requested a review from tsahee January 2, 2025 14:47
@tsahee tsahee requested a review from joshuacolvin0 January 3, 2025 02:33
joshuacolvin0
joshuacolvin0 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge January 3, 2025 02:51
@tsahee tsahee merged commit 910cd85 into master Jan 3, 2025
16 checks passed
@tsahee tsahee deleted the stylus_metrics branch January 3, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee approved these changes

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amsanghi @joshuacolvin0 @tsahee