Merge pull request #163 from OffchainLabs/stub_out_finalize_ref

stub-out js_finalize_ref

arbitrator/jit/src/syscall.rs

@@ -261,18 +261,13 @@ fn get_field(env: &mut WasmEnv, source: u32, field: &[u8]) -> GoValue {
 }
 
 /// go side: λ(v value)
+// TODO: implement ref counting
 pub fn js_finalize_ref(mut env: WasmEnvMut, sp: u32) {
-    let (mut sp, env) = GoStack::new(sp, &mut env);
-    let pool = &mut env.js_state.pool;
+    let (mut sp, _) = GoStack::new(sp, &mut env);
 
     let val = JsValue::new(sp.read_u64());
     match val {
-        JsValue::Ref(x) if x < DYNAMIC_OBJECT_ID_BASE => {}
-        JsValue::Ref(x) => {
-            if pool.remove(x).is_none() {
-                eprintln!("Go trying to finalize unknown ref {}", x);
-            }
-        }
+        JsValue::Ref(_) => {}
         val => eprintln!("Go trying to finalize {:?}", val),
     }
 }

arbitrator/wasm-libraries/go-stub/src/lib.rs

@@ -618,17 +618,13 @@ pub unsafe extern "C" fn go__syscall_js_valueIndex(sp: usize) {
 }
 
 /// Safety: λ(v value)
+/// TODO: reference counting
 #[no_mangle]
 pub unsafe extern "C" fn go__syscall_js_finalizeRef(sp: usize) {
     let mut sp = GoStack::new(sp);
     let val = JsValue::new(sp.read_u64());
     match val {
-        JsValue::Ref(x) if x < DYNAMIC_OBJECT_ID_BASE => {}
-        JsValue::Ref(x) => {
-            if DynamicObjectPool::singleton().remove(x).is_none() {
-                eprintln!("Go attempting to finalize unknown ref {}", x);
-            }
-        }
+        JsValue::Ref(_)  => {}
         val => eprintln!("Go attempting to finalize {:?}", val),
     }
 }