This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Program activated event edits #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsahee
approved these changes
Oct 3, 2023
| @@ -884,18 +884,18 @@ func TestProgramAcivationLogs(t *testing.T) { | |||
| if len(receipt.Logs) != 1 { | |||
| Fatal(t, "expected 1 log while activating, got ", len(receipt.Logs)) | |||
| } | |||
| parsed, err := arbWasm.ParseProgramActivated(*receipt.Logs[0]) | |||
| log, err := arbWasm.ParseProgramActivated(*receipt.Logs[0]) | |||
There was a problem hiding this comment.
log is a bad name for a var.. in most of our codebase log is geth's log module name.
There was a problem hiding this comment.
That's a reasonable argument, though let's keep it for now only because we use that name elsewhere in this folder when we have logs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the following with a few tweaks
Notably
con.ProgramActivatedburns gas, we remove the prior gas check