Disable manifest validation tests until validation issue fixed #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TCourtneyOwen
commented
Dec 2, 2020
TCourtneyOwen
commented
- Manifest Validation Fails on HighResolutionIconURL and IconURL Errors generator-office#590 tracks an issue with manifest validation, which I believe is a bug. I have contacted OMEX about the behavior and suggested they fix it. Several customers have also contacted us about this issue so it's becoming a real problem
- Once the issue is fixed, we will re-enable the tests, but for now we should disable these tests because it will cause our CI loops to fail for all other changes made to Office-Addin-Scripts
- I will open a VSO bug to track re-enabling the tests once the validation issue is fixed
- OfficeDev/generator-office#590 tracks an issue with manifest validation, which I believe is a bug. I have contacted OMEX about the behavior and suggested they fix it. Several customers have also contacted us about this issue so it's becoming a real problem - Once the issue is fixed, we will re-enable the tests, but for now we should disable these tests because it will cause our CI loops to fail for all other changes made to Office-Addin-Scripts - I will open a VSO bug to track re-enabling the tests once the validation issue is fixed
arttarawork
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.