Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Issue #425: Fix hanging StreamingSubscriptionConnection.close() #496

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue #425: Fix hanging StreamingSubscriptionConnection.close() #496

wants to merge 2 commits into from

Commits on Feb 15, 2016

  1. Issue OfficeDev#425: Fix hanging StreamingSubscriptionConnection.close() 

    StreamingSubscriptionConnection.close() calls HttpWebRequest.close() which will first
attempts to consume the response before releasing the connection. This unfortunately
will hang since the notification reader thread is still blocked reading from the same
connection. The fix is to just the connection without consuming the response entity.
    @dconnelly
    dconnelly committed Feb 15, 2016
    Configuration menu
    Copy the full SHA
    ec9d4a8 View commit details
    Browse the repository at this point in the history

  2. Don't invoke disconnect listener if socket was closed because we are … 

    …already disconnecting
    @dconnelly
    dconnelly committed Feb 15, 2016
    Configuration menu
    Copy the full SHA
    bf7a6a1 View commit details
    Browse the repository at this point in the history