added a listener for testing host to test manual initialization on test app #2544
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorJoelHarris
requested changes
Oct 14, 2024
AE-MS
reviewed
Oct 15, 2024
AE-MS
reviewed
Oct 15, 2024
KangxuanYe
force-pushed
the
kx/register_listener_for_test_host
branch
from
b5a9b18
to
32ba922
Compare
AE-MS
reviewed
Oct 16, 2024
AE-MS
reviewed
Oct 16, 2024
TrevorJoelHarris
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
This is a change on test app that it will not go through fixed initialization flow we hard-coded here if one of url parameter is
testInit. Instead, it will have a listener listening to our testing host, waiting for message to call corresponding APIs to complete the initialization flow.Main changes in the PR:
Validation
Unit Tests added: No
End-to-end tests added: No