Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Excel] (Custom Functions) Add new Get started article #4852

Merged
merged 16 commits into from
Dec 23, 2024

Conversation

alison-mk
Copy link
Contributor

No description provided.

@alison-mk alison-mk requested a review from grangeryy October 14, 2024 02:13
Copy link
Contributor

Learn Build status updates of commit 712e066:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit ff08ae3:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@grangeryy grangeryy marked this pull request as ready for review October 18, 2024 02:50
@grangeryy
Copy link

Thank you @alison-mk for putting things together and I've reviewed and approved it!

Copy link
Contributor

Learn Build status updates of commit 90adaef:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a few spots that need a little bit more explanation. thanks!

Copy link
Contributor

Learn Build status updates of commit a961232:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 29a4602:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/images/custom-functions-dynamic-array.png ✅Succeeded View
docs/images/custom-functions-not-dynamic-array.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit b7db7ce:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/images/custom-functions-dynamic-array.png ✅Succeeded View
docs/images/custom-functions-not-dynamic-array.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 5d229bc:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/images/custom-functions-dynamic-array.png ✅Succeeded View
docs/images/custom-functions-not-dynamic-array.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few suggestions in the comments.

Copy link
Contributor

Learn Build status updates of commit cf8a961:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/images/custom-functions-dynamic-array.png ✅Succeeded View
docs/images/custom-functions-not-dynamic-array.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit a2c0fd8:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/images/custom-functions-dynamic-array.png ✅Succeeded View
docs/images/custom-functions-not-dynamic-array.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit f6f242d:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/images/custom-functions-dynamic-array.png ✅Succeeded View
docs/images/custom-functions-not-dynamic-array.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@lindalu-MSFT lindalu-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my note on the custom-functions-delay-image. There's a few other suggestions, too. ~linda

Copy link
Contributor

Learn Build status updates of commit 8871053:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/images/custom-functions-dynamic-array.png ✅Succeeded View
docs/images/custom-functions-not-dynamic-array.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 7c77f0d:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-get-started.md ✅Succeeded View
docs/images/custom-functions-add-in-components.png ✅Succeeded View
docs/images/custom-functions-delay-example.png ✅Succeeded View
docs/images/custom-functions-dynamic-array.png ✅Succeeded View
docs/images/custom-functions-not-dynamic-array.png ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@lindalu-MSFT lindalu-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for fixing the image! It's definitely got enough contrast now.

@alison-mk alison-mk merged commit 1238d20 into main Dec 23, 2024
2 checks passed
@alison-mk alison-mk deleted the alison-mk-cf-get-started branch December 23, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants