Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All hosts] (NAA) Latest NAA updates #4856

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

davidchesnut
Copy link
Member

This updates the walkthrough and FAQ with latest updates around NAA preview and GA.

Copy link
Contributor

Learn Build status updates of commit 8dfeee9:

✅ Validation status: passed

File Status Preview URL Details
docs/develop/enable-nested-app-authentication-in-your-add-in.md ✅Succeeded View
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit c1cae49:

✅ Validation status: passed

File Status Preview URL Details
docs/develop/enable-nested-app-authentication-in-your-add-in.md ✅Succeeded View
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@AlexJerabek AlexJerabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some suggestions.

@@ -61,7 +61,7 @@ The following steps show how to enable NAA in the `taskpane.js` or `taskpane.ts`

```json
"dependencies": {
"@azure/msal-browser": "^3.15.0",
"@azure/msal-browser": "^3.24.0",
...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this is showing up weird in GitHub?

image

| _setActiveAccount_ | NO |
| _setLogger_ | YES |
| _ssoSilent_ | YES |
| *acquireTokenByCode* | NO (throws exception) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of italic, should these method names be in code ticks?

| _setActiveAccount_ | NO |
| _setLogger_ | YES |
| _ssoSilent_ | YES |
| *acquireTokenByCode* | NO (throws exception) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the "YES" and "NO" to "Yes" and "No"?

@@ -59,7 +62,7 @@ To find out whether your add-in uses legacy Exchange user identity tokens and ca

If your add-in calls any of these APIs, you should adopt NAA and migrate to using Entra ID tokens to access Microsoft Graph instead.

We'll provide tooling via PowerShell for Microsoft 365 administrators in October 2024 to turn legacy Exchange tokens on or off in your tenant. This will allow you to test if any add-ins are using Exchange tokens. We'll provide more information when the tooling is ready in this FAQ.
We'll provide tooling via PowerShell for Microsoft 365 administrators in October 2024 to report the app ID of any add-in that used legacy Exchange online tokens in the last 28 days. The tooling will also allow you to turn legacy Exchange online tokens on or off for the entire tenant. We'll provide more information when the tooling is ready in this FAQ.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's October, do we know when this tooling is coming?

Copy link
Contributor

Learn Build status updates of commit 0078882:

✅ Validation status: passed

File Status Preview URL Details
docs/develop/enable-nested-app-authentication-in-your-add-in.md ✅Succeeded View
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 25a1cb2:

✅ Validation status: passed

File Status Preview URL Details
docs/develop/enable-nested-app-authentication-in-your-add-in.md ✅Succeeded View
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants