Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerPoint] (overview) Refresh #4858

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ElizabethSamuel-MSFT
Copy link
Contributor

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT commented Oct 16, 2024

This article had low engagement last month

Copy link
Contributor

Learn Build status updates of commit b432759:

✅ Validation status: passed

File Status Preview URL Details
docs/powerpoint/powerpoint-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, but looks good!


- The `getActiveFileView` function calls the [Document.getActiveViewAsync](/javascript/api/office/office.document#office-office-document-getactiveviewasync-member(1)) method to return whether the presentation's current view is "edit" (any of the views in which you can edit slides, such as **Normal** or **Outline View**) or "read" (**Slide Show** or **Reading View**).

- The `registerActiveViewChanged` function calls the [addHandlerAsync](/javascript/api/office/office.document#office-office-document-addhandlerasync-member(1)) method to register a handler for the [Document.ActiveViewChanged](/javascript/api/office/office.document) event.

```js
//general Office.initialize function. Fires on load of the add-in.
// General Office.initialize function. Fires on loading the add-in.
Office.initialize = function(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use Office.onReady()...

docs/powerpoint/powerpoint-add-ins.md Outdated Show resolved Hide resolved
docs/powerpoint/powerpoint-add-ins.md Outdated Show resolved Hide resolved
docs/powerpoint/powerpoint-add-ins.md Outdated Show resolved Hide resolved
docs/powerpoint/powerpoint-add-ins.md Outdated Show resolved Hide resolved
docs/powerpoint/powerpoint-add-ins.md Outdated Show resolved Hide resolved
docs/powerpoint/powerpoint-add-ins.md Outdated Show resolved Hide resolved
docs/powerpoint/powerpoint-add-ins.md Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit 6bd16d0:

✅ Validation status: passed

File Status Preview URL Details
docs/powerpoint/powerpoint-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit dc72277:

✅ Validation status: passed

File Status Preview URL Details
docs/powerpoint/powerpoint-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants