Skip to content

Commit

Permalink
fix: refine local debug prerequisite check error message
Browse files Browse the repository at this point in the history
  • Loading branch information
jayzhang committed Oct 10, 2024
1 parent b7467c7 commit 4df3d65
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
5 changes: 1 addition & 4 deletions packages/vscode-extension/src/debug/depsChecker/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -598,10 +598,7 @@ async function handleCheckResults(

if (shouldStop) {
await progressHelper?.stop(false);
const message =
getDefaultString(displayMessages.errorMessageKey) +
" " +
displayMessages.showDetailMessage();
const message = failures.map((f) => f.error?.message || "").join(", ");

// show failure summary in display message
const displayMessage =
Expand Down
11 changes: 11 additions & 0 deletions packages/vscode-extension/src/telemetry/vscodeTelemetryReporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
} from "@microsoft/teamsfx-core";
import { configure, getLogger, Logger } from "log4js";
import { workspaceUri } from "../globalVariables";
import VSCodeLogger from "../commonlib/log";

const TelemetryTestLoggerFile = "telemetryTest.log";

Expand Down Expand Up @@ -117,6 +118,11 @@ export class VSCodeTelemetryReporter extends vscode.Disposable implements Teleme
this.logTelemetryErrorEvent(eventName, properties, measurements, errorProps);
} else {
this.reporter.sendTelemetryErrorEvent(eventName, properties, measurements);
void VSCodeLogger.debug(
`sendTelemetryErrorEvent ===> ${eventName}, properties: ${JSON.stringify(
properties
)}, measurements: ${JSON.stringify(measurements)}`
);
}
}

Expand Down Expand Up @@ -144,6 +150,11 @@ export class VSCodeTelemetryReporter extends vscode.Disposable implements Teleme
this.logTelemetryEvent(eventName, properties, measurements);
} else {
this.reporter.sendTelemetryEvent(eventName, properties, measurements);
void VSCodeLogger.debug(
`sendTelemetryEvent ===> ${eventName}, properties: ${JSON.stringify(
properties
)}, measurements: ${JSON.stringify(measurements)}`
);
}
}

Expand Down

0 comments on commit 4df3d65

Please sign in to comment.