refactor: spfx generator component name (#11502)

OfficeDev · Apr 29, 2024 · 622a928 · 622a928
1 parent 21e98f8
commit 622a928
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/fx-core/src/component/generator/spfx/spfxGenerator.ts b/packages/fx-core/src/component/generator/spfx/spfxGenerator.ts
@@ -885,6 +885,7 @@ export class SPFxGenerator {
 }
 
 export class SPFxGeneratorNew extends DefaultTemplateGenerator {
+  componentName = "spfx-new-generator";
   public activate(context: Context, inputs: Inputs): boolean {
     const capability = inputs[QuestionNames.Capabilities] as string;
     const spfxSolution = inputs[QuestionNames.SPFxSolution];
@@ -913,8 +914,8 @@ export class SPFxGeneratorNew extends DefaultTemplateGenerator {
 }
 
 export class SPFxGeneratorImport extends DefaultTemplateGenerator {
+  componentName = "spfx-import-generator";
   importDetails: string[] = [];
-
   public activate(context: Context, inputs: Inputs): boolean {
     const capability = inputs[QuestionNames.Capabilities] as string;
     const spfxSolution = inputs[QuestionNames.SPFxSolution];

diff --git a/packages/fx-core/src/component/generator/templates/templateGenerator.ts b/packages/fx-core/src/component/generator/templates/templateGenerator.ts
@@ -56,7 +56,7 @@ export class DefaultTemplateGenerator implements IGenerator {
     return ok(undefined);
   }
 
-  // override this method to provide information of templates to be generated
+  // override this method to 1) do pre-step before template download and 2) provide information of templates to be downloaded
   public getTemplateInfos(
     context: Context,
     inputs: Inputs,
@@ -68,7 +68,7 @@ export class DefaultTemplateGenerator implements IGenerator {
     return Promise.resolve(ok([{ templateName, language }]));
   }
 
-  // override this method to do post process
+  // override this method to do post-step after template download
   public post(
     context: Context,
     inputs: Inputs,