Skip to content

Commit

Permalink
refactor: pr feedback
Browse files Browse the repository at this point in the history
refactor: string
  • Loading branch information
yuqizhou77 committed Apr 28, 2024
1 parent d13ecd9 commit 9ff7477
Show file tree
Hide file tree
Showing 18 changed files with 24 additions and 24 deletions.
4 changes: 2 additions & 2 deletions packages/fx-core/resource/package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -478,8 +478,8 @@
"core.getUserEmailQuestion.validation2": "Change [UserName] to the real user name",
"core.collaboration.error.failedToLoadDotEnvFile": "Unable to load your .env File. Reason: %s",
"core.selectAadAppManifestQuestion.title": "Select Microsoft Entra manifest.json file",
"core.selectTeamsAppManifestQuestion.title": "Select Teams manifest.json file",
"core.selectTeamsAppPackageQuestion.title": "Select Teams app package file",
"core.selectTeamsAppManifestQuestion.title": "Select Teams manifest.json File",
"core.selectTeamsAppPackageQuestion.title": "Select Teams app package File",
"core.selectLocalTeamsAppManifestQuestion.title": "Select local Teams manifest.json file",
"core.selectCollaborationAppTypeQuestion.title": "Select the app for which you want to manage collaborators",
"core.selectValidateMethodQuestion.validate.selectTitle": "Select a validation method",
Expand Down
4 changes: 2 additions & 2 deletions packages/fx-core/src/question/create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2150,8 +2150,8 @@ export function apiOperationQuestion(
: getLocalizedString("core.createProjectQuestion.apiSpec.operation.title");
},
cliDescription: isAddPlugin
? "Select Operation(s) Copilot Can Interact with."
: "Select Operation(s) Teams Can Interact with.",
? "Select operation(s) Copilot can interact with."
: "Select operation(s) Teams can interact with.",
cliShortName: "o",
placeholder: (inputs: Inputs) => {
const isPlugin =
Expand Down
4 changes: 2 additions & 2 deletions packages/fx-core/src/question/inputs/AddPluginInputs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
import { Inputs } from "@microsoft/teamsfx-api";

export interface AddPluginInputs extends Inputs {
/** @description Select Teams manifest.json file */
/** @description Select Teams manifest.json File */
"manifest-path"?: string;
/** @description Select plugin availability */
/** @description Select Plugin Availability */
"plugin-availability"?: "copilot-plugin" | "action" | "copilot-plugin-and-action";
/** @description OpenAPI Description Document */
"openapi-spec-location"?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import { Inputs } from "@microsoft/teamsfx-api";

export interface PermissionGrantInputs extends Inputs {
/** @description Select Teams manifest.json file */
/** @description Select Teams manifest.json File */
"manifest-path"?: string;
/** @description Select an environment */
env?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import { Inputs } from "@microsoft/teamsfx-api";

export interface PermissionListInputs extends Inputs {
/** @description Select Teams manifest.json file */
/** @description Select Teams manifest.json File */
"manifest-path"?: string;
/** @description Select an environment */
env?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ import { Inputs } from "@microsoft/teamsfx-api";
export interface PreviewTeamsAppInputs extends Inputs {
/** @description Platform */
"m365-host"?: "teams" | "outlook" | "office";
/** @description Select Teams manifest.json file */
/** @description Select Teams manifest.json File */
"manifest-path"?: string;
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export interface SPFxAddWebpartInputs extends Inputs {
"spfx-webpart-name"?: string;
/** @description Framework */
"spfx-framework-type"?: "react" | "minimal" | "none";
/** @description Select Teams manifest.json file */
/** @description Select Teams manifest.json File */
"manifest-path"?: string;
/** @description Select local Teams manifest.json file */
"local-manifest-path"?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
import { Inputs } from "@microsoft/teamsfx-api";

export interface SelectTeamsManifestInputs extends Inputs {
/** @description Select Teams manifest.json file */
/** @description Select Teams manifest.json File */
"manifest-path"?: string;
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
import { Inputs } from "@microsoft/teamsfx-api";

export interface ValidateTeamsAppInputs extends Inputs {
/** @description Select Teams manifest.json file */
/** @description Select Teams manifest.json File */
"manifest-path"?: string;
/** @description Select Teams app package file */
/** @description Select Teams app package File */
"app-package-file-path"?: string;
}
4 changes: 2 additions & 2 deletions packages/fx-core/src/question/options/AddPluginOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const AddPluginOptions: CLICommandOption[] = [
type: "string",
shortName: "t",
description:
"Specifies the Microsoft Teams app manifest template file path, it can be either absolute path or relative path to project root folder, defaults to './appPackage/manifest.json'",
"Specify the path for Teams app manifest template. It can be either absolute path or relative path to the project root folder, with default at './appPackage/manifest.json'",
required: true,
default: "./appPackage/manifest.json",
},
Expand All @@ -39,7 +39,7 @@ export const AddPluginOptions: CLICommandOption[] = [
name: "api-operation",
type: "array",
shortName: "o",
description: "Select Operation(s) Copilot Can Interact with.",
description: "Select operation(s) Copilot can interact with.",
required: true,
},
];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export const CreateProjectOptions: CLICommandOption[] = [
name: "api-operation",
type: "array",
shortName: "o",
description: "Select Operation(s) Teams Can Interact with.",
description: "Select operation(s) Teams can interact with.",
},
{
name: "api-me-auth",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const PermissionGrantOptions: CLICommandOption[] = [
type: "string",
shortName: "t",
description:
"Specifies the Microsoft Teams app manifest template file path, it can be either absolute path or relative path to project root folder, defaults to './appPackage/manifest.json'",
"Specify the path for Teams app manifest template. It can be either absolute path or relative path to the project root folder, with default at './appPackage/manifest.json'",
default: "./appPackage/manifest.json",
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const PermissionListOptions: CLICommandOption[] = [
type: "string",
shortName: "t",
description:
"Specifies the Microsoft Teams app manifest template file path, it can be either absolute path or relative path to project root folder, defaults to './appPackage/manifest.json'",
"Specify the path for Teams app manifest template. It can be either absolute path or relative path to the project root folder, with default at './appPackage/manifest.json'",
default: "./appPackage/manifest.json",
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const PreviewTeamsAppOptions: CLICommandOption[] = [
type: "string",
shortName: "t",
description:
"Specifies the Microsoft Teams app manifest template file path, it can be either absolute path or relative path to project root folder, defaults to './appPackage/manifest.json'",
"Specify the path for Teams app manifest template. It can be either absolute path or relative path to the project root folder, with default at './appPackage/manifest.json'",
required: true,
default: "./appPackage/manifest.json",
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const SPFxAddWebpartOptions: CLICommandOption[] = [
type: "string",
shortName: "t",
description:
"Specifies the Microsoft Teams app manifest template file path, it can be either absolute path or relative path to project root folder, defaults to './appPackage/manifest.json'",
"Specify the path for Teams app manifest template. It can be either absolute path or relative path to the project root folder, with default at './appPackage/manifest.json'",
required: true,
default: "./appPackage/manifest.json",
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const SelectTeamsManifestOptions: CLICommandOption[] = [
type: "string",
shortName: "t",
description:
"Specifies the Microsoft Teams app manifest template file path, it can be either absolute path or relative path to project root folder, defaults to './appPackage/manifest.json'",
"Specify the path for Teams app manifest template. It can be either absolute path or relative path to the project root folder, with default at './appPackage/manifest.json'",
required: true,
default: "./appPackage/manifest.json",
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const ValidateTeamsAppOptions: CLICommandOption[] = [
type: "string",
shortName: "t",
description:
"Specifies the Microsoft Teams app manifest template file path, it can be either absolute path or relative path to project root folder, defaults to './appPackage/manifest.json'",
"Specify the path for Teams app manifest template. It can be either absolute path or relative path to the project root folder, with default at './appPackage/manifest.json'",
default: "./appPackage/manifest.json",
},
{
Expand Down
4 changes: 2 additions & 2 deletions packages/fx-core/src/question/other.ts
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ export function selectTeamsAppManifestQuestion(): SingleFileQuestion {
cliName: "teams-manifest-file",
cliShortName: "t",
cliDescription:
"Specifies the Microsoft Teams app manifest template file path, it can be either absolute path or relative path to project root folder, defaults to './appPackage/manifest.json'",
"Specify the path for Teams app manifest template. It can be either absolute path or relative path to the project root folder, with default at './appPackage/manifest.json'",
title: getLocalizedString("core.selectTeamsAppManifestQuestion.title"),
type: "singleFile",
default: (inputs: Inputs): string | undefined => {
Expand Down Expand Up @@ -978,7 +978,7 @@ export class PluginAvailabilityOptions {
export function selectPluginAvailabilityQuestion(): SingleSelectQuestion {
return {
name: QuestionNames.PluginAvailability,
title: "Select plugin availability",
title: "Select Plugin Availability",
cliDescription: "Select plugin availability.",
type: "singleSelect",
staticOptions: PluginAvailabilityOptions.all(),
Expand Down

0 comments on commit 9ff7477

Please sign in to comment.