Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli cannot scroll down if multiple selections #11521

Merged
merged 4 commits into from
May 7, 2024

Conversation

yuqizhou77
Copy link
Contributor

@yuqizhou77 yuqizhou77 commented May 4, 2024

Bug 27955155: [CLI] Scroll down will error when single select an item of large index from a list
choices.length could be smaller than page size, leading to pageStarter <0.
After fix:
image

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (e1b11d5) to head (d612153).
Report is 8 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11521      +/-   ##
==========================================
+ Coverage   88.19%   88.32%   +0.13%     
==========================================
  Files         535      536       +1     
  Lines       32144    32600     +456     
  Branches     6328     6510     +182     
==========================================
+ Hits        28348    28793     +445     
- Misses       1876     1884       +8     
- Partials     1920     1923       +3     
Files Coverage Δ
packages/cli/src/prompts/utils.ts 97.36% <100.00%> (+2.77%) ⬆️

... and 4 files with indirect coverage changes

@yuqizhou77 yuqizhou77 closed this May 4, 2024
@yuqizhou77 yuqizhou77 reopened this May 7, 2024
@yuqizhou77 yuqizhou77 marked this pull request as ready for review May 7, 2024 02:09
@yuqizhou77 yuqizhou77 merged commit 55aca73 into dev May 7, 2024
36 checks passed
@yuqizhou77 yuqizhou77 deleted the yuqzho/cli-scroll-down-fix branch May 7, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants