Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reenable codegen for CF & codegen quality improve #11524

Merged
merged 7 commits into from
May 8, 2024

Conversation

kh9n
Copy link
Contributor

@kh9n kh9n commented May 6, 2024

A few improvments:

  1. Fix an issue that not able to identify custom functions.
  2. Fix an issue that not able to fetch declaration summaries if the summary contains multiple elements (Link, paragraph, etc.)
  3. Check the token length in the getMostRelevantDeclarationsUsingLLM method and shorten on demand to avoid token overload.
  4. Fix an issue in getMostRelevantDeclarationsUsingLLM that in some case, a few classes will be dropped from the detect methods or property process.
  5. Rewrite some prompts to improve the code generation accurency.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 90.18405% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 88.35%. Comparing base (e1b11d5) to head (96826d0).
Report is 18 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11524      +/-   ##
==========================================
+ Coverage   88.19%   88.35%   +0.16%     
==========================================
  Files         535      536       +1     
  Lines       32144    32304     +160     
  Branches     6328     6324       -4     
==========================================
+ Hits        28348    28541     +193     
+ Misses       1876     1841      -35     
- Partials     1920     1922       +2     
Files Coverage Δ
.../src/officeChat/common/skills/codeIssueDetector.ts 100.00% <100.00%> (ø)
packages/vscode-extension/src/officeChat/consts.ts 100.00% <100.00%> (+25.00%) ⬆️
...s/vscode-extension/src/officeChat/officePrompts.ts 94.95% <100.00%> (+2.85%) ⬆️
packages/vscode-extension/src/officeChat/utils.ts 100.00% <ø> (ø)
...src/officeChat/common/skills/codeIssueCorrector.ts 94.44% <81.81%> (+7.30%) ⬆️
...tension/src/officeChat/common/declarationFinder.ts 87.25% <71.42%> (-1.51%) ⬇️
...sion/src/officeChat/common/skills/codeGenerator.ts 94.15% <87.50%> (+8.22%) ⬆️
...on/src/officeChat/common/samples/sampleProvider.ts 94.33% <93.47%> (+18.51%) ⬆️

... and 9 files with indirect coverage changes

@1openwindow 1openwindow merged commit 9a42061 into OfficeDev:dev May 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants