Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tdp error messages #12509

Merged
merged 20 commits into from
Oct 15, 2024
Merged

refactor: tdp error messages #12509

merged 20 commits into from
Oct 15, 2024

Conversation

anchenyi
Copy link
Contributor

@anchenyi anchenyi commented Oct 11, 2024

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 90.41096% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (e9244f2) to head (eefcacd).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages/fx-core/src/client/teamsDevPortalClient.ts 89.65% 3 Missing and 3 partials ⚠️
packages/fx-core/src/common/wrappedAxiosClient.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #12509      +/-   ##
==========================================
+ Coverage   89.67%   89.77%   +0.09%     
==========================================
  Files         583      580       -3     
  Lines       34631    34169     -462     
  Branches     6823     6793      -30     
==========================================
- Hits        31056    30674     -382     
+ Misses       1583     1551      -32     
+ Partials     1992     1944      -48     
Files with missing lines Coverage Δ
...es/fx-core/src/component/driver/teamsApp/errors.ts 72.54% <100.00%> (+2.17%) ⬆️
packages/fx-core/src/error/teamsApp.ts 100.00% <100.00%> (ø)
packages/fx-core/src/common/wrappedAxiosClient.ts 88.19% <80.00%> (+0.14%) ⬆️
...ackages/fx-core/src/client/teamsDevPortalClient.ts 89.10% <89.65%> (-0.71%) ⬇️

... and 9 files with indirect coverage changes

@anchenyi anchenyi marked this pull request as ready for review October 14, 2024 07:05
@anchenyi anchenyi merged commit e7bb724 into dev Oct 15, 2024
18 checks passed
@anchenyi anchenyi deleted the anchenyi/tdp_error_message branch October 15, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants