Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(da): update build logic to support separate ac in plugin file #13139

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

SLdragon
Copy link
Contributor

@SLdragon SLdragon commented Feb 8, 2025

No description provided.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.28%. Comparing base (d2d7cd2) to head (dbc5443).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/component/driver/teamsApp/createAppPackage.ts 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #13139   +/-   ##
=======================================
  Coverage   90.27%   90.28%           
=======================================
  Files         584      584           
  Lines       35126    35151   +25     
  Branches     7029     6973   -56     
=======================================
+ Hits        31711    31735   +24     
  Misses       1484     1484           
- Partials     1931     1932    +1     
Files with missing lines Coverage Δ
.../src/component/driver/teamsApp/createAppPackage.ts 94.84% <96.42%> (+0.12%) ⬆️

@SLdragon SLdragon merged commit 44a9e2b into dev Feb 8, 2025
19 checks passed
@SLdragon SLdragon deleted the rentu-update28 branch February 8, 2025 06:46
hermanwenhe pushed a commit to hermanwenhe/TeamsFx that referenced this pull request Feb 11, 2025
…fficeDev#13139)

* perf(da): update build logic to support separate ac in plugin file

* fix: test cases and do not use tmp folder

* fix: add missing test resources

* fix: typo

---------

Co-authored-by: rentu <rentu>
hermanwenhe pushed a commit to hermanwenhe/TeamsFx that referenced this pull request Feb 11, 2025
…fficeDev#13139)

* perf(da): update build logic to support separate ac in plugin file

* fix: test cases and do not use tmp folder

* fix: add missing test resources

* fix: typo

---------

Co-authored-by: rentu <rentu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants