Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if serviceWorker is supported #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tutacat
Copy link

@tutacat tutacat commented Aug 19, 2024

Tested working on gecko/firefox and blink/chromium

Copy link
Author

@tutacat tutacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, newline

@Offroaders123
Copy link
Owner

Thanks for the contribution!

I think I didn't add the check for it initially because it seems like all modern browsers support Service Workers nowadays. Is there another situation where navigator.serviceWorker might not be declared?

Information about it does seem to show that the check is used commonplace, however much of the original documentation for Service Workers seems to be from 2016-2018.

I could see a take of wanting to use Dovetail on older browsers that don't support Service Workers, but I'm also not sure how much marketshare those realistic have anymore. Dovetail's backing relies on fairly modern APIs that are in modern browsers too, so much of the actual app wouldn't work even if the Service Worker call didn't break the whole site.

Thanks again for contributing this, I don't mean to be over analyzing this, I just want to see if there's any more info I might not know about whether the check is still viable nowadays. Always something to learn from 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants