Skip to content

Commit

Permalink
Switch embedded icon from 128 px² to 256 px²
Browse files Browse the repository at this point in the history
... and embed a GIF (v89a) icon in RPMs, but not in XPM (v3) file format!

XPM is absolutely antiquated (it describes a picture as text!), results in large file sizes (no built-in compression) and of lower image quality than GIF (though both are "8 bit colour palette plus transparency, with 24 bit colours" formats).
GIF89a is technically much more modern than XPMv3 and `rpmbuild` only accepts GIF and XPM icons!
  • Loading branch information
Olf0 authored Jan 5, 2020
1 parent 2493433 commit 1f5186e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rpm/obexd-contentfilter-off.spec
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Source: https://github.com/Olf0/%{name}/archive/%{version}/%{name}-%{vers
# rpmbuild (as of v4.14.1) handles the Icon tag awkwardly and in contrast to the Source tag(s):
# It only accepts a GIF or XPM file (successfully tested GIF89a and XPMv3) in the SOURCE directory
# (but not in the tarball)! Hence only to be used, when the file is put there:
# Icon: kdebluetooth.128x128.gif
# Icon: kdebluetooth.256x256.gif
BuildArch: noarch
Provides: obexd-contentfilter-helper
# Obsoleting a vendor supplied system package (i.e., from a mandatory repository) is best
Expand Down

0 comments on commit 1f5186e

Please sign in to comment.