Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Tokenizer implementation #26

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

C++ Tokenizer implementation #26

wants to merge 5 commits into from

Conversation

OlivierBinette
Copy link
Owner

Check if release PR fulfills these requirements

  • Changelog has been updated and breaking changes have been marked (if any).
  • Tests have been added if necessary.

Type of change

  • Breaking changes.
  • Backward compatible feature additions.
  • Backward compatible bug fixes.

Additional comments and description of changes

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

Merging #26 (0167206) into dev (7b9c58b) will decrease coverage by 4.26%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev      #26      +/-   ##
==========================================
- Coverage   81.31%   77.04%   -4.27%     
==========================================
  Files          15       15              
  Lines         305      305              
==========================================
- Hits          248      235      -13     
- Misses         57       70      +13     
Flag Coverage Δ
unittests 77.04% <50.00%> (-4.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stringcompare/distance/__init__.py 100.00% <ø> (ø)
stringcompare/preprocessing/tokenizer.py 0.00% <0.00%> (-61.91%) ⬇️
stringcompare/preprocessing/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9c58b...0167206. Read the comment docs.

@OlivierBinette OlivierBinette changed the title begin work C++ Tokenizer implementation Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants