Fix partials to indent as demanded by the mustache spec #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
fix/indented-partials
branch
from
635058f
to
341b9db
Compare
The mustache specs [1] and testsuite [2], as well as the lustache README.md [3] demand that partials be indented. [1]: http://mustache.github.io/mustache.5.html [2]: https://github.com/mustache/spec/blob/v1.1.3/specs/partials.yml#L82-L100 [3]: https://github.com/Olivine-Labs/lustache#partials
ghost
force-pushed
the
fix/indented-partials
branch
from
341b9db
to
ee65a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mustache specs 1 and testsuite 2, as well as the lustache README.md 3
demand that partials be indented.
Be warned: This is a horrible hack that searches the start of the current line during partials rendering and indents the rendered lines after the fact. I assume it is possible to track beginnings of lines during parsing and use that information while rendering partials, but I could not figure out how.