Skip to content

Commit

Permalink
1.4.18 Security issue correction.
Browse files Browse the repository at this point in the history
  • Loading branch information
OllieJones committed May 15, 2024
1 parent f526ad1 commit 015fb2a
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 26 deletions.
3 changes: 3 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,6 @@ Miscellaneous bug fixes.

= 1.4.17 =
Back out a miscellaneous bug fix from the previous version. It was an attempt to avoid a warning from Query Monitor's hooks display.

= 1.4.18 =
Security update.
3 changes: 2 additions & 1 deletion code/admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ private function getMonitorName() {
*/
private function insertHelpTab( $monitor, $sHTML ) {
$tabSlug = $monitor ? 'monitor' : $this->oProp->getCurrentTabSlug();
$helpUrl = index_wp_mysql_for_speed_help_site . $tabSlug;
$tabSlug = ctype_alnum ( $tabSlug ) ? $tabSlug : 'about';
$helpUrl = index_wp_mysql_for_speed_help_site . $tabSlug;
$help = __( 'Help', 'index-wp-mysql-for-speed' );
/** @noinspection HtmlUnknownTarget */
$helpTag = '<a class="helpbutton nav-tab" target="_blank" href="%s/">%s</a>';
Expand Down
2 changes: 1 addition & 1 deletion code/assets/mu/index-wp-mysql-for-speed-update-filter.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/** Plugin Name: Index WP MySQL For Speed Upgrade Filter for mu-plugins.
* Description: Prevents version upgrades from changing database table keys. Installed during activation, removed during deactivation.
* Version: 1.4.17
* Version: 1.4.18
* License: GPL v2 or later
*/

Expand Down
4 changes: 2 additions & 2 deletions index-wp-mysql-for-speed.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* Plugin Name: Index WP MySQL For Speed
* Plugin URI: https://plumislandmedia.org/index-wp-mysql-for-speed/
* Description: Speed up your WordPress site by adding high-performance keys (database indexes) to your MySQL database tables.
* Version: 1.4.17
* Version: 1.4.18
* Requires at least: 4.2
* Tested up to: 6.5
* Requires PHP: 5.6
Expand All @@ -28,7 +28,7 @@
*/

/** current version number */
define( 'index_wp_mysql_for_speed_VERSION_NUM', '1.4.17' );
define( 'index_wp_mysql_for_speed_VERSION_NUM', '1.4.18' );
define( 'index_mysql_for_speed_major_version', 1.4 );
define( 'index_mysql_for_speed_inception_major_version', 1.3 );
define( 'index_mysql_for_speed_inception_wp_version', '5.8.3' );
Expand Down
31 changes: 9 additions & 22 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Tags: index, key, performance, mysql, wp-cli
Requires at least: 4.2
Tested up to: 6.5
Requires PHP: 5.6
Stable tag: 1.4.17
Stable tag: 1.4.18
Network: true
License: GPL v2 or later
License URI: https://www.gnu.org/licenses/gpl-2.0.html
Expand Down Expand Up @@ -88,7 +88,7 @@ Give the command `wp help index-mysql` for details. A few examples:
* `wp index-mysql status` shows the current status of high-performance keys.
* `wp index-mysql enable --all` adds the high-performance keys to all tables that don't have them.
* `wp index-mysql enable wp_postmeta` adds the high-performance keys to the postmeta table.
* `wp index-mysql disable --all` removes the high-performance keys from all tables that have them, restore WordPress's default keys.
* `wp index-mysql disable --all` removes the high-performance keys from all tables that have them, restoring WordPress's default keys.
* `wp index-mysql enable --all --dryrun` writes out the SQL statements necessary to add the high-performance keys to all tables, but does not run them.
* `wp index-mysql enable --all --dryrun | wp db query` writes out the SQL statements and pipes them to wp db to run them.

Expand Down Expand Up @@ -228,12 +228,19 @@ Database keying works by making copies of your table’s data organized in ways

**Yes**. Once the high-performance keys are in place MariaDB and MySQL automatically maintain them as you update, delete, or insert rows of data to your tables. There is no need to do anything to apply the keys to new data: the DBMS software does that for you.

= How do I revert to WordPress's standard keys, undoing the action of this plugin? =

You can revert the keys from the Index MySQL Tool under the Tools menu, or use the wp-cli command `wp index-mysql disable --all`. *Notice* that if you deactivate or delete the plugin without doing this, the high-performance keys *remain*.

= How do I get an answer to another question? =

Please see more questions and answers [here](https://plumislandmedia.net/index-wp-mysql-for-speed/faq/).

== Changelog ==

= 1.4.18 =
Security update.

= 1.4.17 =
Back out a miscellaneous bug fix from the previous version. It was an attempt to avoid a warning from Query Monitor's hooks display.
Upload the full MariaDB / MySQL version information with monitors as well as metadata.
Expand All @@ -246,26 +253,6 @@ Avoid attempting to upgrade from storage engines except MyISAM and Aria.
WP-CLI upgrade, enable, and disable commands are idempotent now. They don't generate errors when they find no tables to process.
Miscellaneous bug fixes

= 1.4.15 =
(no changes to keys)
Add a Database Health section to the About tab showing some performance metrics.
Avoid doing EXPLAIN DESCRIBE when capturing monitors.
Clear the dashboard upgrade nag after doing `wp index-mysql status`.
Put backticks around table names in data definition language statements.

= 1.4.14 =
(no changes to keys)
Handle database version 55853 (no schema changes).
Deal with php 8.2 deprecations.

= 1.4.13 =
(no changes to keys)
Support MariaDB 11.x in version-detection code.

= 1.4.12 =
(no changes to keys)
Change max_statement_time session variable if necessary to avoid "Query execution was interrupted" errors.
Do ANALYZE TABLE after each rekeying operation.

== Upgrade Notice ==

Expand Down

0 comments on commit 015fb2a

Please sign in to comment.