Merge pull request #701 from filipw/bugfix/constructor-signature

fixed constructor signature helper
OmniSharp · Dec 6, 2016 · d151846 · d151846
2 parents 793228f + 601239b
commit d151846
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/src/OmniSharp.Roslyn.CSharp/Services/Signatures/SignatureHelpService.cs b/src/OmniSharp.Roslyn.CSharp/Services/Signatures/SignatureHelpService.cs
@@ -172,20 +172,12 @@ private int InvocationScore(IMethodSymbol symbol, IEnumerable<TypeInfo> types)
             return score;
         }
 
-        private SignatureHelpItem BuildSignature(IMethodSymbol symbol)
+        private static SignatureHelpItem BuildSignature(IMethodSymbol symbol)
         {
             var signature = new SignatureHelpItem();
             signature.Documentation = symbol.GetDocumentationCommentXml();
-            if (symbol.MethodKind == MethodKind.Constructor)
-            {
-                signature.Name = symbol.ContainingType.Name;
-                signature.Label = symbol.ContainingType.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat);
-            }
-            else
-            {
-                signature.Name = symbol.Name;
-                signature.Label = symbol.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat);
-            }
+            signature.Name = symbol.MethodKind == MethodKind.Constructor ? symbol.ContainingType.Name : symbol.Name;
+            signature.Label = symbol.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat);
 
             signature.Parameters = GetParameters(symbol).Select(parameter =>
             {
@@ -196,6 +188,7 @@ private SignatureHelpItem BuildSignature(IMethodSymbol symbol)
                     Documentation = parameter.GetDocumentationCommentXml()
                 };
             });
+
             return signature;
         }