fix(react): restore useAtomSelector mounted state when swapping inline refs
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowheart
added a commit
that referenced
this pull request
Jul 30, 2024
bowheart
added a commit
that referenced
this pull request
Aug 31, 2024
bowheart
added a commit
that referenced
this pull request
Sep 5, 2024
bowheart
added a commit
that referenced
this pull request
Sep 8, 2024
bowheart
added a commit
that referenced
this pull request
Sep 16, 2024
bowheart
added a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
useAtomSelectorimplementation had a copy-paste error - when settingmountedto false temporarily while swapping out inline refs, the code never actually set it back to true, instead setting it to false again. This meant inline selectors would lose their subscription after the 2nd update (it would go: First render, first update, second render, swap ref and destroy subscription). No test cases and my simple testing never checked beyond the second render.Add a regression test for this that makes sure inline selectors stay subscribed across four renders.