Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify uniswap v3pair to extend heuristic for swaps #381

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Modify uniswap v3pair to extend heuristic for swaps #381

wants to merge 3 commits into from

Conversation

ponyjackal
Copy link
Contributor

No description provided.

@pcowgill pcowgill changed the title Feature/ou 2413 modify uniswap v3pair to extend heuristic for swaps Modify uniswap v3pair to extend heuristic for swaps May 24, 2024
pcowgill
pcowgill requested changes May 24, 2024
View reviewed changes
Copy link
Contributor

@pcowgill pcowgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other change to make: If tx.from is not the same as the receiver and the receiver receives more than 1 asset, fall back to catchall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcowgill pcowgill pcowgill requested changes

@jordanmessina jordanmessina Awaiting requested review from jordanmessina

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ponyjackal @pcowgill