Add v3 Transaction Types #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guscost
approved these changes
May 28, 2024
src/types/transaction.ts
Outdated
| netAssetTransfers: { | ||
| [address: string]: { | ||
| received: [{ type; contract; value; tokenId? }]; | ||
| sent: [{ type; contract; value; tokenId? }]; |
There was a problem hiding this comment.
Could we add the type of each of these sub-object properties so we have more than just the names?
| }; | ||
| isContract: boolean; | ||
| tokenStandard: string; | ||
| imgUrl: string; |
There was a problem hiding this comment.
We use imageUrl below, but I suppose this has to be accurate, maybe call it out with a comment until we can update.
Also I would add comments stating explicitly that all these structures are in progress, like https://github.com/Once-Upon/docs/pull/22/files
There was a problem hiding this comment.
cdt-eth
commented
May 28, 2024
src/types/transaction.ts
Outdated
| contract: string; | ||
| tokenId?: string; | ||
| }; | ||
|
|
There was a problem hiding this comment.
didn't realize we already had a type for this
guscost
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.