Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated CI_BUILD_* predefined variables #105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GlennM
Copy link

@GlennM GlennM commented Mar 29, 2022

The predefined CI/CD variables that start with CI_BUILD_* were deprecated in GitLab 9.0, and will be removed in GitLab 16.0
The replacement predefined variables are functionally identical.

Source

@OndraM
Copy link
Owner

OndraM commented Apr 12, 2022

Hi, thanks for the pull request. But - correct me if I'm wrong - the new Gitlab >9 variables are already supported, so this is just removal of the deprecated variables?

If so, I don't think they necessarily needs to be removed right now - keeping them is no cost. We can at least wait until GitLab 16 (which will be released probably next year)...

@GlennM
Copy link
Author

GlennM commented Apr 12, 2022

Indeed, the variables have been deprecated since 2017 and will be removed completely in 2023.
I was preparing my projects for the new GitLab 15 which will be released next month and found some hits in this package so I prepared this package.
I'm fine with keeping the deprecated variables until GitLab 16 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants