-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/jmx-setup #112
Feat/jmx-setup #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I'd love to see the contents of oba/Dockerfile.jmx
get merged into oba/Dockerfile
, and the new features exposed in the docker-compose-jmx.yml
file get merged into docker-compose.yml
, docker-compose.standalone.yml
, and docker-compose.prod.yml
. (after that let's just delete docker-compose-jmx.yml
)
I think monitoring via JMX exporter should be a core part of our Docker image's offering, and I think that the changes outlined here—on top of the great work you've done— will get us there!
Let me know if you need any help updating the oba/Dockerfile
. It's a bit complicated :)
Actually, in the beginning, they were merged, but I separated them so they could be optional. |
@aaronbrethorst Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good!
To test the JMX exporter, follow these steps:
Verify the JMX Exporter:
http://localhost:1234/metrics