Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background shading in arrival list #1102

Merged

Conversation

kungharrison
Copy link
Contributor

@kungharrison kungharrison commented Jan 7, 2024

Fix for #451 regarding inconsistent background shading behind cards.

Changes:
arrivals_list_empty_style.xml: arrival_list_background background color was added to arrivals_list_empty_style.xml to add the background color properly when the arrival list is empty.
ArrivalsListFragment.java: Apply background color to root view of list view, this sets the arrival_list_background color properly to the entire area.

Screenshots:
Arrival List when empty before fix:
image
Arrival List when empty after fix:
image
Arrival List with content before fix:
image
Arrival List with content after fix:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.
  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest connectedObaAmazonDebugAndroidTest to make sure you didn't break anything
  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

@aaronbrethorst
Copy link
Member

Hi @kungharrison - Apologies for not responding to your PR until now! I thought I had notifications turned on for this repo, but I guess I don't 🥲

I'll review this soon and let you know if I have any feedback. much obliged!

@kungharrison
Copy link
Contributor Author

@aaronbrethorst Thanks! I've been using this app for a while, so I thought I would contribute. This is my first PR as well so let me know if there are any issues.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🚀

@aaronbrethorst aaronbrethorst merged commit 015b3fa into OneBusAway:master Jan 12, 2024
2 checks passed
@aaronbrethorst
Copy link
Member

@kungharrison 2.11.1, which includes this change, was just published in the Play Store. Thanks again! Also, please reach out to me at [email protected]. I'd love to add you to our Slack group.

@kungharrison
Copy link
Contributor Author

Also I believe we can now close issue #241

@aaronbrethorst
Copy link
Member

@kungharrison I think you mean #451, but I have now closed it :)

@kungharrison kungharrison deleted the fix-background-shading branch January 24, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants