Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1121 - Correct spacing between my location & bike-sharing button #1122

Closed
wants to merge 7 commits into from

Conversation

amrhossamdev
Copy link
Member

Fixed #1121

  • Increasing the margin between the two buttons
  • Refactor: Instead of using left and right it's better to use start and end for RTL support.

I have tested different scenarios for the two buttons like opening the arrivals list / using locations that don't have bike-sharing options

Screenshots:

correct2 correct1 Screenshot_1708878024

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

@amrhossamdev amrhossamdev changed the title Fixed #1121 - Correct Spacing Between my location & bikesharing Button Fixed #1121 - Correct spacing between my location & bike-sharing button Feb 25, 2024
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tackling this! I think the end result looks great, but I have a couple requests for the code:

  1. Please try to make the necessary changes via the XML view instead of the visual designer so that the minimum number of lines of code change as necessary (the visual designer seems to do a lot of indentation changes and property rearranging).
  2. I agree with you on the RTL work, but we should adopt the necessary changes across the board instead of in one piece of UI. So, for now, let's keep this consistent and maybe open a task to track full RTL conversion.

@amrhossamdev
Copy link
Member Author

amrhossamdev commented Feb 28, 2024

Alright, I will fix that, I only did a reformat for the code so a lot of spacing was added and removed.

updated: I have updated main.xml and changed only one line of the spacing.

@amrhossamdev amrhossamdev deleted the branch OneBusAway:main February 28, 2024 13:19
@amrhossamdev amrhossamdev deleted the main branch February 28, 2024 13:19
@amrhossamdev amrhossamdev restored the main branch February 28, 2024 13:19
@amrhossamdev amrhossamdev reopened this Feb 28, 2024
@amrhossamdev
Copy link
Member Author

I will close this and open a new PR with changes because I have deleted my main branch to assign for each issue a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI - Bike sharing floating action button incorrect spacing
2 participants