fix: Enhanced layout of "About" Activity #1139
Conversation
Okay, I will get it done. |
|
Implemented @aaronbrethorst in a new pull request #1148. |
| @@ -52,7 +56,14 @@ protected void onCreate(Bundle savedInstanceState) { | |||
|
|
|||
| getSupportActionBar().setDisplayHomeAsUpEnabled(true); | |||
|
|
|||
| TextView tv = (TextView) findViewById(R.id.about_text); | |||
| // TextView tv = (TextView) findViewById(R.id.about_text); | |||
There was a problem hiding this comment.
I guess it would be better if we could just remove unused code
| builder.append("\n\n"); | ||
|
|
||
| tv.setText(builder.toString()); | ||
| // builder.append(getString(R.string.about_text)); |
There was a problem hiding this comment.
Same as above, I personally feel we could just remove this
| <string name="translations_sub_heading">Translations:</string> | ||
| <string name="contribute_to_our_app_sub_heading">Join the Journey: Contribute to Our App!</string> | ||
| <string name="app_description">At OneBusAway, we\'re passionate about creating innovative solutions to simplify your transit experience. Our Android app is a labor of love, made possible by the dedication and talent of a diverse group of individuals and organizations. Here\'s a glimpse into the fantastic contributors who have made OneBusAway what it is today:</string> | ||
| <string name="code_contributors_content"><
|
Ahh sorry, never mind, when I had a look there were no other comments. |
fix #1138
Follow Material UI design pattern.
After:
After.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
gradlew connectedObaGoogleDebugAndroidTestto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)