Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1157 - Dialog crash #1159

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fixed #1157 - Dialog crash #1159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions onebusaway-android/src/main/java/org/onebusaway/android/ui/SituationDialogFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,12 @@ public void onClick(DialogInterface dialog, int which) {
TextView title = (TextView) dialog.findViewById(R.id.alert_title);
title.setText(args.getString(TITLE));

TextView desc = (TextView) dialog.findViewById(R.id.alert_description);
TextView descTxtView = (TextView) dialog.findViewById(R.id.alert_description);

if (desc != null) {
desc.setText(Html.fromHtml(args.getString(DESCRIPTION)));
String desc = args.getString(DESCRIPTION);

if (descTxtView != null &&!TextUtils.isEmpty(desc)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please be sure to watch your formatting on lines like this. I'd prefer to see this as:

if (descTxtView != null && !TextUtils.isEmpty(desc)) {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting me, it's more clear now!

descTxtView.setText(Html.fromHtml(desc));
}
TextView urlView = (TextView) dialog.findViewById(R.id.alert_url);

Expand Down
Loading