feat: scan registry for installed driver, progress bar #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabi1cazenave
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Awesome to see some refinements on this feature. Two remarks :
- let’s avoid nested code with a few early returns — I was about to refactor your code with that, but since we’re at it…
- would it be possible / relevant to display the two phases (creating the installer / building the DLL), as mentioned in [msklc] add a progress bar #145 ?
|
|
||
| [[tool.mypy.overrides]] | ||
| module = ["progress.bar"] | ||
| ignore_missing_imports = true |
There was a problem hiding this comment.
why do we need this here ?
and what does the double [[ ]] mean ?
There was a problem hiding this comment.
[[]] means array, needed for this setting
and this is needed to avoid mypy to check progress code it seems. Otherwise I get an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a section in pyproject to disable mypy on third party lib
progress